Skip to content

Docs: improve docs narrative around "ENSNode Plugins", "ENSDb Writers", and "ENSDb Readers".#2227

Merged
tk-o merged 33 commits into
mainfrom
docs/improve-ensdb-writer-reader-ensnode-plugins
Jun 4, 2026
Merged

Docs: improve docs narrative around "ENSNode Plugins", "ENSDb Writers", and "ENSDb Readers".#2227
tk-o merged 33 commits into
mainfrom
docs/improve-ensdb-writer-reader-ensnode-plugins

Conversation

@tk-o
Copy link
Copy Markdown
Member

@tk-o tk-o commented May 30, 2026

Suggested review order

Integration section

  1. https://ensnodeio-git-docs-improve-ensdb-writer-reader-2e7baf-namehash.vercel.app/docs/integrate/integration-options/ensdb
  2. https://ensnodeio-git-docs-improve-ensdb-writer-reader-2e7baf-namehash.vercel.app/docs/integrate/integration-options/ensdb-writers
  3. https://ensnodeio-git-docs-improve-ensdb-writer-reader-2e7baf-namehash.vercel.app/docs/integrate/integration-options/ensdb-readers
  4. https://ensnodeio-git-docs-improve-ensdb-writer-reader-2e7baf-namehash.vercel.app/docs/integrate/integration-options/ensnode-plugins

Services section

  1. https://ensnodeio-git-docs-improve-ensdb-writer-reader-2e7baf-namehash.vercel.app/docs/services/ensdb
  2. https://ensnodeio-git-docs-improve-ensdb-writer-reader-2e7baf-namehash.vercel.app/docs/services/ensdb/concepts/glossary
  3. https://ensnodeio-git-docs-improve-ensdb-writer-reader-2e7baf-namehash.vercel.app/docs/services/ensdb/integrations
  4. https://ensnodeio-git-docs-improve-ensdb-writer-reader-2e7baf-namehash.vercel.app/docs/services/ensindexer/contributing/creating-a-plugin

Why

This PR is a followup to PR #2199, and PR #2202, and addresses the "Big Feedback" (point 11. and 17.) section the doc discussed in this thread, as well as the feedback shared in this thread.

More feedback was shared in [this Slack thread(https://namehash.slack.com/archives/C086Z6FNBHN/p1780339533610239) as well and this PR address all the points that were raised in the thread.

This PR also updates the ENSDb glossary around "ENSDb Writer" and "ENSDb Reader" (details about this update were discussed here).

Next steps

Tasks below will be executed in follow up PRs.

  1. Create extensive set of examples for the ENS Unigraph module within the "Integrate" section.
    • Optimise UX/UI for presenting examples (i.e. use tables for presenting SQL query results).
  2. Optimise docs in the "Sefl-host" section.

Copilot AI review requested due to automatic review settings May 30, 2026 14:00
@tk-o tk-o requested a review from a team as a code owner May 30, 2026 14:00
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 30, 2026

⚠️ No Changeset found

Latest commit: d5d982f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
admin.ensnode.io Ready Ready Preview, Comment Jun 3, 2026 7:15pm
enskit-react-example.ensnode.io Ready Ready Preview, Comment Jun 3, 2026 7:15pm
ensnode.io Ready Ready Preview, Comment Jun 3, 2026 7:15pm
ensrainbow.io Ready Ready Preview, Comment Jun 3, 2026 7:15pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2026

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds three integration concepts—ENSDb Writers, ENSDb Readers, ENSNode Plugins—by creating dedicated docs pages, updating the Integration Options index and Starlight sidebar, repositioning ENSIndexer as an ENSDb Writer reference implementation, and aligning cross-document links, glossary entries, and hosted-instances plugin links.

Changes

ENSDb & ENSNode Plugins Architecture

Layer / File(s) Summary
Sidebar Navigation Configuration
docs/ensnode.io/config/integrations/starlight/sidebar-topics/integrate.ts, docs/ensnode.io/config/integrations/starlight/sidebar-topics/services.ts
Starlight sidebar updated to expose ENSDb Writers, ENSDb Readers, and ENSNode Plugins; ENSDb Concepts subtree simplified and ENSIndexer contributing label changed to "Creating an ENSNode Plugin".
ENSDb Writers & Readers Foundation Pages
docs/.../integration-options/ensdb-writers.mdx, docs/.../integration-options/ensdb-readers.mdx
New pages describing ENSDb Writers (indexer responsibilities, metadata writer requirement, examples) and ENSDb Readers (ENSApi Omnigraph/Subgraph, reader tips, current/new readers) with LinkCards and CTAs.
ENSNode Plugins Specification
docs/.../integration-options/ensnode-plugins.mdx
New page defining ENSNode Plugin spec fields, interoperability note for Omnigraph queries, a table of existing plugins, development notes, and LinkCards to Writers/Readers.
Integration Options Index Reorganization
docs/.../integration-options/index.mdx, docs/.../integration-options/ensdb.mdx
Inserted numbered sections for Writers/Readers/Plugins, renumbered subsequent sections, simplified ENSDb examples/learn-more card set, and clarified ENSDb standard description regarding writer/reader coordination and metadata persistence.
Service Documentation & Shared Terminology
docs/.../services/ensindexer/index.mdx, docs/.../services/ensindexer/contributing/creating-a-plugin.mdx, docs/.../services/ensdb/index.mdx, docs/.../services/ensdb/concepts/glossary.mdx
ENSIndexer described as an ENSDb Writer reference implementation; ENSIndexer plugin guide rewritten to document ENSNode plugin structure/activation; ENSDb Getting Started content and glossary updated to reflect metadata-writer responsibilities and corrected SDK includes.
Cross-Document Reference Updates
docs/.../omnigraph/concepts.mdx, docs/.../unigraph/schema-reference.mdx, docs/.../integrate/ensv2-readiness.mdx, docs/.../integrate/unigraph/index.mdx
Updated language and links to identify unigraph as an ENSNode plugin and to separate its documentation link from the ENSIndexer implementation reference.
Hosted-instances links
docs/.../hosted-instances.mdx
Added exported pluginLink helper and replaced static/emphasized plugin name strings with linked plugin names in multiple hosted instance entries.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • namehash/ensnode#2121 — Overlapping ENS integration docs edits (ENSv2/ENSDb framing and unigraph/ENSApi references).
  • namehash/ensnode#2171 — Related sidebar/navigation changes affecting Integrate sidebar entries.
  • namehash/ensnode#2199 — Hosted-instances docs edits overlapping plugin-linking and instance listings.

Suggested labels

docs

Poem

"A rabbit hops through docs so bright,
New Writers, Readers, Plugins in sight.
ENSIndexer stands as the guide,
LinkCards and indexes now aligned.
Hoppity-hop — docs feel light! 🐇"

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description lacks required sections from template: missing 'Summary', 'Why', 'Testing', and 'Pre-Review Checklist' as specified in the repository template. Restructure the description to follow the 'Lite PR' template: add concise Summary (1-3 bullets), Why section with issue links, Testing section, and complete the Pre-Review Checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: improving documentation narrative around three related concepts (ENSNode Plugins, ENSDb Writers, and ENSDb Readers).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/improve-ensdb-writer-reader-ensnode-plugins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 30, 2026

Greptile Summary

This PR improves the documentation narrative around three key architectural concepts: ENSNode Plugins, ENSDb Writers, and ENSDb Readers. It restructures the ENSDb service docs (flattening the Usage and Integrations sections), adds new dedicated pages for each concept under the Integrate section, and updates all glossary definitions to reflect the new, more abstract terminology — replacing ENSIndexer-specific terms like "ENSIndexer Schema" with the implementation-agnostic "ENSDb Writer Schema".

  • Three new integration-options pages (ensdb-writers.mdx, ensdb-readers.mdx, ensnode-plugins.mdx) and two new service pages (integrations.mdx, reference-implementation.mdx) are added; redundant usage/ pages are removed with corresponding redirects.
  • Glossary definitions for ENSDb Standard, ENSDb Writer, ENSDb Reader, and related schema concepts are updated to reflect the generic architecture, and new "ENSDb Metadata Writer" and "ENSNode Plugin" terms are introduced.
  • Redirects for five retired URL paths are added to astro.config.mjs, covering previously flagged missing entries for integrations/ensnode and integrations/future-possibilities.

Confidence Score: 5/5

Documentation-only changes with well-formed redirects and consistent terminology updates throughout; safe to merge.

All changes are documentation content and sidebar configuration. The five new redirect rules correctly cover removed and renamed pages. The terminology migration from ENSIndexer-specific terms to the implementation-agnostic ENSDb Writer/ENSDb Reader vocabulary is applied consistently across all modified files. The only finding is a cosmetic rendering issue (raw HTML in a string prop) that does not affect navigation, correctness, or build integrity.

docs/ensnode.io/src/content/docs/docs/services/ensdb/integrations.mdx has a display-only issue with an HTML tag in a LinkCard description string.

Important Files Changed

Filename Overview
docs/ensnode.io/astro.config.mjs Adds 5 redirect rules for removed/renamed pages, including the previously flagged missing redirects for integrations/ensnode and integrations/future-possibilities.
docs/ensnode.io/src/content/docs/docs/services/ensdb/integrations.mdx New page replacing usage/index.mdx; contains raw HTML <code> tag inside a LinkCard description string that will render as literal text rather than styled code.
docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensnode-plugins.mdx New page providing the full ENSNode Plugin specification; terminology is consistent with the rest of the docs and links are well-formed.
docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb-writers.mdx New page describing ENSDb Writers; content is accurate, links are well-formed, and the Envio/Amp/ENSIndexer sections are clearly structured.
docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb-readers.mdx New page describing ENSDb Readers; ENSAnalytics LinkCard now has href="/docs/services" as a placeholder (previously flagged missing href is addressed).
docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Comprehensive terminology update: ENSIndexer Schema → ENSDb Writer Schema, new ENSNode Plugin and ENSDb Metadata Writer entries added, all within-page anchors are correct.
docs/ensnode.io/src/content/docs/docs/services/ensdb/reference-implementation.mdx New page with a Mermaid flowchart showing the three-component reference implementation; all links are valid.
docs/ensnode.io/src/components/molecules/EnsDbWriterSchemaIntro.astro New component replacing EnsIndexerSchemaIntro.astro; prop name updated to ensDbWriterSchemaName, all callsite usages are consistent.
docs/ensnode.io/config/integrations/starlight/sidebar-topics/services.ts Simplifies ENSDb sidebar from nested Usage/Integrations groups to flat Integrations and Reference Implementation entries; sidebar label for creating-a-plugin renamed to ENSNode Plugins.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    NP["ENSNode Plugin\n(abstract spec)"]
    EW["ENSDb Writer\nimplements plugins + metadata writer"]
    EM["ENSDb Metadata Writer\nwrites metadata to ENSNode Schema"]
    ER["ENSDb Reader\nreads indexed data + metadata"]
    EDB[("ENSDb Instance\nPostgreSQL")]
    EWS["ENSDb Writer Schema\nindexed ENS data"]
    ENS["ENSNode Schema\noperational metadata"]

    NP -->|"implemented by"| EW
    EW -->|"includes"| EM
    EW -->|"writes indexed data to"| EWS
    EM -->|"writes metadata to"| ENS
    EWS -->|"lives in"| EDB
    ENS -->|"lives in"| EDB
    ER -->|"reads from"| EDB

    style NP fill:#e8f4fd,stroke:#2980b9
    style EW fill:#eafaf1,stroke:#27ae60
    style ER fill:#fef9e7,stroke:#f39c12
Loading

Reviews (18): Last reviewed commit: "Fix typo" | Re-trigger Greptile

Comment thread docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the documentation narrative around ENSNode Plugins, ENSDb Writers, and ENSDb Readers, positioning ENSIndexer/ENSApi explicitly as reference implementations and adding dedicated integration-option pages to explain the architecture and interoperability model.

Changes:

  • Reframes ENSIndexer docs to describe it as an ENSDb Writer reference implementation and clarifies how it implements ENSNode Plugins.
  • Expands the ENSDb glossary with definitions for ENSNode Plugin and ENSDb Metadata Writer, and updates related metadata terminology.
  • Adds new integration-option pages for ENSDb Writers, ENSDb Readers, and ENSNode Plugins, and links them from the integration options index + sidebar.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
docs/ensnode.io/src/content/docs/docs/services/ensindexer/index.mdx Repositions ENSIndexer as a reference ENSDb Writer and links to glossary terminology.
docs/ensnode.io/src/content/docs/docs/services/ensindexer/contributing/creating-a-plugin.mdx Renames/reframes the page to explain ENSNode Plugins and ENSIndexer’s plugin implementation structure.
docs/ensnode.io/src/content/docs/docs/services/ensdb/index.mdx Updates “What you can build” section to point readers to integration inspirations.
docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Adds/updates key definitions (ENSNode Plugin, ENSDb Writer/Reader, Metadata Writer) and metadata terminology.
docs/ensnode.io/src/content/docs/docs/integrate/unigraph/schema-reference.mdx Updates wording/links to refer to Unigraph as an ENSNode Plugin implemented in ENSIndexer.
docs/ensnode.io/src/content/docs/docs/integrate/omnigraph/concepts.mdx Updates wording/links to refer to Unigraph as an ENSNode Plugin implemented in ENSIndexer.
docs/ensnode.io/src/content/docs/docs/integrate/integration-options/index.mdx Adds new top-level integration options for Writers/Readers/Plugins and renumbers subsequent sections.
docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensnode-plugins.mdx New page describing the ENSNode Plugin specification and listing core/community plugins.
docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb.mdx Adds paragraph explaining ENSDb’s metadata spec and links to Writers/Readers pages.
docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb-writers.mdx New page describing the ENSDb Writer spec and reference/partner implementations.
docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb-readers.mdx New page describing the ENSDb Reader spec and reference reader apps.
docs/ensnode.io/src/content/docs/docs/integrate/ensv2-readiness.mdx Updates wording/links to refer to Unigraph as an ENSNode Plugin implemented in ENSIndexer.
docs/ensnode.io/config/integrations/starlight/sidebar-topics/services.ts Renames the ENSIndexer contributing sidebar item to “ENSNode Plugins”.
docs/ensnode.io/config/integrations/starlight/sidebar-topics/integrate.ts Adds sidebar entries for Writers/Readers/Plugins integration-option pages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/ensnode.io/src/content/docs/docs/services/ensdb/index.mdx Outdated
Comment thread docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Outdated
Comment thread docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Outdated
Comment thread docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Outdated
Comment thread docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Outdated
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb-readers.mdx`:
- Around line 44-47: The LinkCard for "Learn more about ENSAnalytics (coming
soon)" is missing the required href prop; update the LinkCard component in
ensdb-readers.mdx to include an href (e.g., a placeholder route like
"/ensanalytics" or a temporary external URL) so the
`@astrojs/starlight/components` LinkCard receives a valid href, keeping the title
"ENSAnalytics" and description unchanged; ensure the href is a string literal
and points to the placeholder until the real route exists.

In
`@docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb-writers.mdx`:
- Line 11: The bullet under "writer responsibilities" contains a malformed
fragment "How to process onchain data into (including transforming raw onchain
data into a desired internal data model)"; replace it with a complete,
grammatical sentence such as "How to process on‑chain data, including
transforming raw on‑chain data into a desired internal data model" so the
responsibility reads clearly—update the writer responsibilities bullet in the
ENSDB writers section to use that full sentence.

In
`@docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb.mdx`:
- Line 14: Update the interoperability phrasing in the sentence referencing the
"ENSDb standard" so that it reads "...supports decoupling and interop with any
EnsDbReader implementation." Locate the sentence that mentions "EnsDbWriters",
"ENSDb instance" and "EnsDbReaders" and replace the fragment "interop with any
of EnsDbReaders" with "interop with any EnsDbReader implementation" to tighten
grammar and clarity.

In
`@docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensnode-plugins.mdx`:
- Line 23: In the paragraph starting with "ENSNode Plugins are the key
architectural piece..." replace both occurrences of the phrase "standards
compliant" with the hyphenated form "standards-compliant" to make the compound
adjective consistent and improve readability; update the two instances that
describe an ENSDb Writer producing a "standards-compliant ENSDb" and an ENSDb
Reader being "standards-compliant" so both are hyphenated.

In `@docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx`:
- Line 70: Update the glossary sentence for ENSDb Reader to avoid "sole ENSDb
Writer" — in the ENSDb Reader definition replace "the sole [ENSDb
Writer](`#ensdb-writer`)" with either "an [ENSDb Writer](`#ensdb-writer`)" or "the
configured [ENSDb Writer](`#ensdb-writer`) for the reader context" so it aligns
with the multi-tenant model; edit the sentence in the ENSDb Reader paragraph in
glossary.mdx (the line containing "Any application that reads ENS data...")
accordingly.
- Around line 64-65: Update the broken self-link and grammar in the ENSDb
glossary sentence: change the relative link
"docs/services/ensdb/concepts/glossary#ensnode-metadata-table" to an absolute
path by adding a leading "/" (i.e.
"/docs/services/ensdb/concepts/glossary#ensnode-metadata-table") and fix the
agreement typo by replacing "instance that have" with "instance that has" in the
same paragraph referring to ENSIndexer and the ENSNode Metadata Table.

In
`@docs/ensnode.io/src/content/docs/docs/services/ensindexer/contributing/creating-a-plugin.mdx`:
- Around line 11-13: Replace the inconsistent glossary terms in this document:
change occurrences of `EnsDbWriter`, `EnsDbWriters`, and `EnsDbReaders` to the
canonical capitalized forms `ENSDb Writer`, `ENSDb Writers`, and `ENSDb Readers`
respectively so they match the rest of the docs; update both the inline mentions
and any link text (e.g., the two instances in the second paragraph and the first
sentence) while preserving existing links/URLs and surrounding punctuation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 17b3bbe3-d245-47a9-85d0-e73061144aee

📥 Commits

Reviewing files that changed from the base of the PR and between 62fd0c9 and 2e61b46.

📒 Files selected for processing (14)
  • docs/ensnode.io/config/integrations/starlight/sidebar-topics/integrate.ts
  • docs/ensnode.io/config/integrations/starlight/sidebar-topics/services.ts
  • docs/ensnode.io/src/content/docs/docs/integrate/ensv2-readiness.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb-readers.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb-writers.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensnode-plugins.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/integration-options/index.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/omnigraph/concepts.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/unigraph/schema-reference.mdx
  • docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx
  • docs/ensnode.io/src/content/docs/docs/services/ensdb/index.mdx
  • docs/ensnode.io/src/content/docs/docs/services/ensindexer/contributing/creating-a-plugin.mdx
  • docs/ensnode.io/src/content/docs/docs/services/ensindexer/index.mdx

Comment thread docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb.mdx Outdated
Comment thread docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Outdated
Comment thread docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Outdated
Copilot AI review requested due to automatic review settings May 30, 2026 14:18
@vercel vercel Bot temporarily deployed to Preview – ensrainbow.io May 30, 2026 14:18 Inactive
@vercel vercel Bot temporarily deployed to Preview – admin.ensnode.io May 30, 2026 14:18 Inactive
Comment thread docs/ensnode.io/src/content/docs/docs/integrate/index.mdx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.

Comment thread docs/ensnode.io/src/content/docs/docs/hosted-instances.mdx Outdated
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
docs/ensnode.io/src/content/docs/docs/services/ensdb/index.mdx (1)

31-36: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Qualify the lead sentence to match the plugin-scoped section.

The new heading says "Indexed ENS State", but Line 33 still reads as if every ENSDb instance contains the full live ENS state. That contradicts the note immediately below and revives the same completeness claim that was previously called out.

✏️ Suggested edit
- An **ENSDb instance** contains the **live onchain state of ENS**.
+ An **ENSDb instance** contains the **live onchain state of ENS as indexed by its activated ENSNode plugins**.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/ensnode.io/src/content/docs/docs/services/ensdb/index.mdx` around lines
31 - 36, The lead sentence under the "Indexed ENS State" heading incorrectly
asserts completeness; update the sentence that currently reads "An ENSDb
instance contains the live onchain state of ENS." to qualify that the instance
only contains the portion of the live onchain ENS state indexed by its active
plugins (for example: "An ENSDb instance contains the portion of the live
onchain ENS state indexed by its active plugins."). Ensure you update the
sentence near the "Indexed ENS State" heading so it aligns with the existing
plugin-scoped note below.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/ensnode.io/src/content/docs/docs/hosted-instances.mdx`:
- Line 23: Remove the stray thematic break line consisting of `---` that appears
after the exported constants and before the first heading in the MDX page (it's
rendering as an unintended horizontal rule); simply delete that line so the
frontmatter/exported constants flow directly into the page body and no
page-level separator is rendered.

---

Duplicate comments:
In `@docs/ensnode.io/src/content/docs/docs/services/ensdb/index.mdx`:
- Around line 31-36: The lead sentence under the "Indexed ENS State" heading
incorrectly asserts completeness; update the sentence that currently reads "An
ENSDb instance contains the live onchain state of ENS." to qualify that the
instance only contains the portion of the live onchain ENS state indexed by its
active plugins (for example: "An ENSDb instance contains the portion of the live
onchain ENS state indexed by its active plugins."). Ensure you update the
sentence near the "Indexed ENS State" heading so it aligns with the existing
plugin-scoped note below.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: df0eca42-e1fd-4fd9-b392-bd23b1620985

📥 Commits

Reviewing files that changed from the base of the PR and between b278eff and 3aa5d30.

📒 Files selected for processing (7)
  • docs/ensnode.io/src/content/docs/docs/hosted-instances.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/index.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/integration-options/ensdb.mdx
  • docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/index.mdx
  • docs/ensnode.io/src/content/docs/docs/services/ensdb/index.mdx
  • docs/ensnode.io/src/content/docs/docs/services/ensdb/reference-implementation.mdx
  • docs/ensnode.io/src/content/docs/docs/services/ensindexer/contributing/creating-a-plugin.mdx

Comment thread docs/ensnode.io/src/content/docs/docs/hosted-instances.mdx Outdated
Please enter the commit message for your changes. Lines starting
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Comment thread docs/ensnode.io/src/content/docs/docs/integrate/index.mdx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

docs/ensnode.io/src/content/docs/docs/services/ensdb/integrations.mdx:4

  • This page is routed and linked from the Services sidebar as “Integrations” (/docs/services/ensdb/integrations), but its frontmatter title is “Using ENSDb”. That mismatch makes navigation/search/breadcrumbs harder to follow (sidebar says one thing, page H1 says another). Consider aligning the page title with the sidebar label (or vice-versa).

Comment thread docs/ensnode.io/src/content/docs/docs/hosted-instances.mdx
Comment thread docs/ensnode.io/src/content/docs/docs/integrate/index.mdx
Comment thread docs/ensnode.io/src/content/docs/docs/hosted-instances.mdx
Comment thread docs/ensnode.io/astro.config.mjs
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 6 comments.

Comment thread docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Outdated
Comment thread docs/ensnode.io/src/content/docs/docs/integrate/unigraph/schema-reference.mdx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 1 comment.

Comment thread docs/ensnode.io/src/content/docs/docs/services/ensdb/concepts/glossary.mdx Outdated
Copy link
Copy Markdown
Member

@Y3drk Y3drk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tk-o

Not an expert on our backend, so I cannot say much about the narrative changes, but all looks good code-wise 🚀

Feel free to have a go at the suggested small UI refinements in a follow-up PR 🫡 .

| `indexing_metadata_context` | [Indexing metadata context](#indexing-metadata-context) of the [ENSIndexer instance](#ensindexer-instance) |
| Key | Description |
| --------------------------- | ------------------------------------------------------------------------------------------------------ |
| `indexing_metadata_context` | [Indexing metadata context](#indexing-metadata-context) for the [ENSDb Writer](#ensdb-writer) instance |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styles of links inside tables do not match the styling of our "normal" links.

Image

Not sure if that's intentional or not.
The potential fix is out of scope for this PR, so I suggest we do it in a follow-up PR (provided that we want to unify the link styles)

import HostedInstanceVersionWarning from "@components/molecules/HostedInstanceVersionWarning.astro";
import EnsSubgraphCorrectnessPostEnsV2Launch from "@components/molecules/EnsSubgraphCorrectnessPostEnsV2Launch.astro";

export const pluginLink = (pluginName) => `<a href="/docs/integrate/integration-options/ensnode-plugins#existing-plugins" class="underline">${pluginName}</a>`;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good thing to refine in the follow-up PR would be the styling of this link. It doesn't match our other links quite yet (but it's close!!!)

Image

NOTE: The change is out of scope for this PR, so I'd recommend applying the fix in a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants